馃悰 fix(pdf-merger): restore file uploading by dragging - #99
Conversation
The previous commit that introduced the pointer-event based list reordering mechanism left an orphaned `drop` and `dragend` listener inside `onPointerMove`. This listener was originally written to handle the HTML5 drag/drop API, but because it was left inside the pointer event logic, it intercepted file upload drags that were meant for the `dropZone` wrapper and broke functionality. Replaced the orphaned listener with the missing `onPointerUp` function, correctly completing the pointer-events list reordering refactor without intercepting OS file drop actions. Co-authored-by: immineal <[email protected]>
|
馃憢 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 馃憖 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
What
Restores the ability to drag and drop external PDF files into the PDF Merger tool.
Why
During a prior refactor, an orphaned
draganddropblock from the legacy list reordering system was left dangling, intercepting file drags before they could hit thedropZoneelement logic.Solution
Removed the legacy code and replaced it with
onPointerUpto correctly finalize the list reordering logic.PR created automatically by Jules for task 75398665197852935 started by @immineal