🔒 Fix DOM XSS in URL Tools - #98
Conversation
Co-authored-by: immineal <[email protected]>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🎯 What: Fixed a DOM Cross-Site Scripting (XSS) vulnerability in the URL Tools query parameter editor (
tools/url-tools/index.html).?test="><script>alert(1)</script>), the application would concatenate those values directly into an HTML string and render them viainnerHTML. This allowed arbitrary JavaScript execution within the user's session.🛡️ Solution: Replaced the insecure
innerHTML +=string interpolation approach with proper DOM element creation (document.createElement()). Untrusted data is now safely assigned to the.valueproperty of input fields, ensuring the browser strictly interprets the data as text content and not executable HTML.PR created automatically by Jules for task 17784246588021282778 started by @immineal