Regenerate data dictionaries + bundle-manifest RE aid (from Beelzebub fork)#175
Draft
imm0r wants to merge 2 commits into
Draft
Regenerate data dictionaries + bundle-manifest RE aid (from Beelzebub fork)#175imm0r wants to merge 2 commits into
imm0r wants to merge 2 commits into
Conversation
Re-extract the translation dictionaries (mods, stats, monsters, uniques, base items, skills) from the current game's GGPK/bundles using the PoeDataExtract tool, so the overlay resolves internal string keys to the live patch's display names. - data/*.tsv: regenerated maps. Notable: unique_item_name_map grows from a near-empty stub to full coverage; monster_name_map drops stale daemon/summon junk keys. Key format for monsters is now the full metadata path (the reader already normalizes both short-id and full-path keys). - ggpk-tools/PoeDataExtract/Program.cs: extractor adjustments used to produce the maps above. This is machine-generated data for the current patch; regenerate again on future patches rather than hand-editing. (cherry picked from commit 86e36b3f709ca41e65e7b2393d7e57d85ddbadbe)
Version bump and CLAUDE.md note for the cherry-picked data-dictionary regeneration + bundle-manifest extractor command. Co-Authored-By: Claude Opus 4.8 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
External contribution from Beelzebub (
[email protected]), forwarded by email and cherry-picked (author preserved) onto ourmaster. Regenerates thedata/*.tsvdictionaries against the current game patch via the ggpk-tools extractor, and adds one read-only extractor command used to locate GGPK patch targets. Independent of any code path — safe to take first.The feature commit (
86e36b3) was authored on the contributor's fork master, which sits ~208 commits ahead of ourorigin/master; this branch is the single feature commit cherry-picked onto our current master (not the whole branch diff), plus a version-bump/docs commit.Changes
data/*.tsv— regenerated dictionaries (mod_name_map,monster_name_map,stat_name_map,stat_desc_map,unique_item_name_map,base_item_*,map_mod_list,skill_name_map, …). Bulk machine-generated data.ggpk-tools/PoeDataExtract/Program.cs— newmanifestverb: deterministic<path>\t<size>\t<bundle>dump of every bundle file, sorted by path (--matchsubstring filter,--outputfile). Diffing a clean vs. patched bundle manifest surfaces exactly which file a patch changed — even a same-size edit — because the third column is the file's bundle and a GGPK patcher repacks the modified file into its own patch bundle. Read-only RE aid; this is how the camera-zoom patch'scharacter.ottarget was found.0.45.13.300+ CLAUDE.md note.Test plan
master; version files bumped in sync.dotnet buildofggpk-toolsto confirm the newmanifestverb compiles.Game patch version verified against
Data regenerated against the contributor's current patch — please confirm it matches the patch you're on (the TSVs are patch-specific).
Notes for the reviewer
Provenance: cherry-picked from
https://github.com/BeelzebubSupreme/PoEformance(pr/data-dict-regen, commit86e36b3), original author retained. The huge insertion/deletion count is wholesale TSV replacement, not logic churn.🤖 Generated with Claude Code
https://claude.ai/code/session_013UCQfY5KTNcmggpfapfciC
Generated by Claude Code