fix(finish): allow finish for draft-PR looms with closed issues and merged PRs#1019
Merged
Conversation
…erged PRs Allow `il finish` to proceed when the issue is already closed if the loom has an associated draft PR. Add early exit path when the draft PR is already merged/closed — skip rebase/validate/commit and go straight to cleanup. Fix ignite test mock to include SettingsManager dependency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
il finishto proceed when the issue is already closed if the loom has an associated draft PR (previously threw an error requiring--force)Test plan
il finishon a loom with a closed issue + draft PR proceeds without--forceil finishon a loom with an already-merged draft PR skips to cleanup