Accept alternative checkmating moves in puzzles#10
Open
Qelxiros wants to merge 1 commit into
Open
Conversation
Puzzle validation previously accepted only the single scripted UCI move from the Lichess solution line. When a player finds a different checkmate than the one scripted, the puzzle is still solved — a mate ends the game regardless of which mating move is played (matching Lichess's own rule). validateAndApply now accepts an off-solution move if it delivers mate, and marks the puzzle solved immediately. The relaxation is intentionally narrow: only mating alternatives are accepted, since the puzzle data carries no eval signal for non-mate alternatives and the scripted engine reply only makes sense in response to the scripted move. Co-Authored-By: Claude Opus 4.8 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Puzzle validation previously accepted only the single scripted UCI move from the Lichess solution line. That's too strict in one well-defined case: when a player finds a different checkmate than the one scripted. A mate ends the game — the puzzle is solved regardless of which mating move was played. This matches how Lichess itself handles it.
Change
validateAndApplynow accepts an off-solution move ifpos.Update(mv).Status() == chess.Checkmate, and marks the puzzle solved immediately (even if the scripted line had more moves — e.g. the player found a shorter mate).The relaxation is intentionally narrow — only mating alternatives are accepted:
ELO submission is driven by client-side solved/unsolved state (the server doesn't re-validate moves), so this client-side change is sufficient.
Tests
TestPuzzleAcceptsAlternativeMate— multiple queen mates available; scripted line isQh1#, player playsQh2#→ accepted, stateSuccess.TestPuzzleRejectsNonMateAlternative— an off-solution non-mating move (Qa2) → stillFailure.All client tests pass.
🤖 Generated with Claude Code