chore(iii-directory): deprecate in favor of directory (final v1.0.1)#294
chore(iii-directory): deprecate in favor of directory (final v1.0.1)#294guibeira wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughDeprecation notices for the Changesiii-directory Deprecation Notices
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
skill-check — worker0 verified, 22 skipped (no docs/).
Four for four. Nicely done. |
iii-directory has been renamed to directory. Flag the worker as deprecated so users migrate before the rename lands: - emit a deprecation WARN at startup (skipped in --manifest mode), pointing users to `iii worker add directory`; version is read dynamically from CARGO_PKG_VERSION - add a deprecation notice to the top of the README - flag the registry description as [DEPRECATED] No version bump here — the Create Tag workflow bumps the manifest and cuts the final iii-directory release. No functional/API change (the function namespace was already directory::*).
2ffe790 to
311ddc3
Compare
What
Flag the
iii-directoryworker as deprecated so users migrate todirectory(the renamed worker, see #266) before the rename lands. Should merge before #266.Changes
WARNat boot (skipped in--manifestmode so machine output stays clean), pointing users toiii worker add directory. Version is read dynamically fromCARGO_PKG_VERSION.> [!WARNING]notice at the top.[DEPRECATED — renamed to directory; final iii-directory release]iniii.worker.yaml(surfaces in registry / console /iii worker info).No manual version bump — the
Create Tagworkflow bumps the manifest and cuts the finaliii-directoryrelease. No functional/API change (the namespace was alreadydirectory::*).Startup output
(the version shown reflects whatever the Create Tag release cuts)
Verification
cargo fmt --check✓ ·cargo build✓ · 249 unit + 44/44 BDD ✓validate_worker.pyEXIT=0 ✓Release
After merge: run Create Tag (worker=
iii-directory, bump=patch) → cuts the final release; then merge #266.Summary by CodeRabbit
Documentation
iii-directoryhas been renamed todirectory. This is the final release under the old name. Users are instructed to migrate usingiii worker add directory. The public API namespace remains unchanged.Chores