refactor(acp): rename crate iii-acp -> acp#263
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthroughRenames the Changesiii-acp → acp Rename
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
skill-check — worker0 verified, 22 skipped (no docs/).
Four for four. Nicely done. |
Binary [[bin]] name and worker manifest bin: stay iii-acp; package name, lib, and imports remain acp.
cargo fmt reorders imports after iii_acp->acp rename. acp is a stdio JSON-RPC server that exits on stdin EOF when backgrounded, so it can't be interface-smoked; opt out via interface_smoke: false (same as lsp).
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
acp/README.md (1)
35-43: 💤 Low valueSpecify language for fenced code block.
The code fence should include a language identifier for proper rendering and linting compliance. Use
textfor ASCII diagrams.✨ Proposed fix
-``` +```text Editor (Zed, VS Code, Neovim, …)🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@acp/README.md` around lines 35 - 43, The fenced code block in the README.md file that contains the ASCII diagram starting with "Editor (Zed, VS Code, Neovim, …)" is missing a language identifier. Add the language identifier `text` immediately after the opening triple backticks to specify that this is a text-based ASCII diagram. This ensures proper rendering and linting compliance for the markdown document.Source: Linters/SAST tools
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@acp/README.md`:
- Line 140: The command examples in the README use the incorrect binary name
`acp` when the actual binary name defined in Cargo.toml is `iii-acp`. This
causes users to get "command not found" errors when they copy the examples.
Replace all occurrences of `acp` with `iii-acp` in the command examples shown in
the documentation. This includes the examples that demonstrate usage with flags
like `--use-canonical-brain` and `--model`. Ensure consistency across all
command examples so they match the correct binary name and align with the proper
reference shown elsewhere in the documentation.
---
Nitpick comments:
In `@acp/README.md`:
- Around line 35-43: The fenced code block in the README.md file that contains
the ASCII diagram starting with "Editor (Zed, VS Code, Neovim, …)" is missing a
language identifier. Add the language identifier `text` immediately after the
opening triple backticks to specify that this is a text-based ASCII diagram.
This ensures proper rendering and linting compliance for the markdown document.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 6d5168fe-b854-4c94-9bba-676066457fad
⛔ Files ignored due to path filters (1)
acp/Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (7)
acp/Cargo.tomlacp/README.mdacp/iii.worker.yamlacp/src/handler.rsacp/src/main.rsacp/src/session.rsacp/tests/protocol.rs
|
|
||
| ```bash | ||
| iii-acp --use-canonical-brain --model claude-sonnet-4-5-20250929 --provider anthropic | ||
| acp --use-canonical-brain --model claude-sonnet-4-5-20250929 --provider anthropic |
There was a problem hiding this comment.
Command examples use wrong binary name.
These examples show acp as the command, but the actual binary name in Cargo.toml line 22 is iii-acp. Users who copy these commands will get "command not found" errors. The binary reference at line 167 (/path/to/iii-acp) is correct.
Update these command examples to use iii-acp instead of acp.
📝 Proposed fix for command examples
-acp --use-canonical-brain --model claude-sonnet-4-5-20250929 --provider anthropic
+iii-acp --use-canonical-brain --model claude-sonnet-4-5-20250929 --provider anthropicApply the same change at lines 203 and 310.
Also applies to: 203-203, 310-310
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@acp/README.md` at line 140, The command examples in the README use the
incorrect binary name `acp` when the actual binary name defined in Cargo.toml is
`iii-acp`. This causes users to get "command not found" errors when they copy
the examples. Replace all occurrences of `acp` with `iii-acp` in the command
examples shown in the documentation. This includes the examples that demonstrate
usage with flags like `--use-canonical-brain` and `--model`. Ensure consistency
across all command examples so they match the correct binary name and align with
the proper reference shown elsewhere in the documentation.
Summary
Renames the Rust crate-level identifiers for the ACP worker from the
iii-acp/iii_acpprefix toacp. The folder (acp/), worker manifestname:(acp), and CI allowlist entry (acp) were already prefix-free, so only the crate/lib/bin identifiers and their references changed.This is Task 3 of the in-repo
iii-prefix removal plan.Changes
acp/Cargo.toml: packagenameiii-acp->acp;[lib] nameiii_acp->acp;[[bin]] nameiii-acp->acp.acp/iii.worker.yaml:bin: iii-acp->bin: acp.acp/src/**+acp/tests/**:iii_acp::/use iii_acplib paths and theiii_acp=...tracing filter ->acp.acp/README.md+ source comments:iii-acpstring references ->acp.acp/Cargo.lock: package entry rename + alphabetical re-sort (no dependency version changes).Out of scope / untouched
iii-sdk,iii-observability,iii-state,iii-stream,iii-queue) — unchanged.github.com/iii-hq/workers),iii-enginekeyword/description references — unchanged.Verification
cargo build— PASS (acp v0.1.0).cargo test— PASS (17 unit + 10 protocol integration tests; no engine required).validate_worker.py --worker acp --base-ref main --source-changed '["acp"]'— PASS (exit 0;name=acpmatches folder).iii-acp/iii_acp(excludingnode_modules,target/) — clean.Summary by CodeRabbit
Chores
Configuration