Skip to content

refactor(acp): rename crate iii-acp -> acp#263

Open
guibeira wants to merge 3 commits into
mainfrom
refactor/rename-iii-acp
Open

refactor(acp): rename crate iii-acp -> acp#263
guibeira wants to merge 3 commits into
mainfrom
refactor/rename-iii-acp

Conversation

@guibeira

@guibeira guibeira commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

Summary

Renames the Rust crate-level identifiers for the ACP worker from the iii-acp / iii_acp prefix to acp. The folder (acp/), worker manifest name: (acp), and CI allowlist entry (acp) were already prefix-free, so only the crate/lib/bin identifiers and their references changed.

This is Task 3 of the in-repo iii-prefix removal plan.

Changes

  • acp/Cargo.toml: package name iii-acp -> acp; [lib] name iii_acp -> acp; [[bin]] name iii-acp -> acp.
  • acp/iii.worker.yaml: bin: iii-acp -> bin: acp.
  • acp/src/** + acp/tests/**: iii_acp:: / use iii_acp lib paths and the iii_acp=... tracing filter -> acp.
  • acp/README.md + source comments: iii-acp string references -> acp.
  • acp/Cargo.lock: package entry rename + alphabetical re-sort (no dependency version changes).

Out of scope / untouched

  • External SDK deps (iii-sdk, iii-observability, iii-state, iii-stream, iii-queue) — unchanged.
  • GitHub URLs (github.com/iii-hq/workers), iii-engine keyword/description references — unchanged.

Verification

  • cargo build — PASS (acp v0.1.0).
  • cargo test — PASS (17 unit + 10 protocol integration tests; no engine required).
  • validate_worker.py --worker acp --base-ref main --source-changed '["acp"]' — PASS (exit 0; name=acp matches folder).
  • Sanity grep for iii-acp / iii_acp (excluding node_modules, target/) — clean.

Summary by CodeRabbit

  • Chores

    • Rebranded worker package name and CLI command from iii-acp to acp across all components and documentation.
    • Updated internal module namespacing to align with new naming scheme.
  • Configuration

    • Disabled interface smoke testing in worker configuration.

@vercel

vercel Bot commented Jun 15, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
workers Ready Ready Preview, Comment Jun 17, 2026 12:02pm

Request Review

@coderabbitai

coderabbitai Bot commented Jun 15, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Renames the iii-acp worker to acp throughout: the Cargo package and library target names, Rust module imports, CLI command name, EnvFilter module selectors, startup log, agentInfo.name protocol field, error message prefixes, doc comments, CI interface_smoke config, protocol tests, and all README documentation.

Changes

iii-acp → acp Rename

Layer / File(s) Summary
Cargo manifest, CLI entry point, and runtime identifiers
acp/Cargo.toml, acp/src/main.rs, acp/src/handler.rs, acp/src/session.rs, acp/iii.worker.yaml
Package and lib target names changed to acp. main.rs switches imports, CLI command name, EnvFilter selectors, and startup log. handler.rs updates agentInfo.name, error prefixes, and doc comments. session.rs updates a group_id comment. iii.worker.yaml adds interface_smoke: false for CI.
Protocol test namespace updates
acp/tests/protocol.rs
All type references in protocol tests switched from iii_acp::types to acp::types for JSON-RPC response construction, session params deserialization, and parse-error tests.
README documentation rename
acp/README.md
All iii-acp references replaced with acp across intro, stack diagrams, client wiring, setup, spawn examples, Zed config, CLI guidance, Brain contract, and streaming protocol sections.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • iii-hq/workers#63: Originally introduced the iii-acp/iii_acp worker package, CLI, and types module that this PR renames.
  • iii-hq/workers#86: Added acp::types structs and protocol tests in the same acp/tests/protocol.rs file updated here.

Suggested reviewers

  • sergiofilhowz

Poem

🐇 A name tag swap, so clean and neat,
iii-acp hops off, acp takes the seat.
The CLI bows, the README bows too,
Tests all agree — the rename sailed through.
No logic changed, just letters reborn,
A bunny approves on this fine morn! 🌱

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title clearly and concisely summarizes the main change: renaming the crate from iii-acp to acp, which is the primary objective.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor/rename-iii-acp

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

skill-check — worker

0 verified, 22 skipped (no docs/).

Layer Result
structure
vale
ai
render

Four for four. Nicely done.

Binary [[bin]] name and worker manifest bin: stay iii-acp; package
name, lib, and imports remain acp.
cargo fmt reorders imports after iii_acp->acp rename. acp is a stdio
JSON-RPC server that exits on stdin EOF when backgrounded, so it can't
be interface-smoked; opt out via interface_smoke: false (same as lsp).

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
acp/README.md (1)

35-43: 💤 Low value

Specify language for fenced code block.

The code fence should include a language identifier for proper rendering and linting compliance. Use text for ASCII diagrams.

✨ Proposed fix
-```
+```text
 Editor (Zed, VS Code, Neovim, …)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@acp/README.md` around lines 35 - 43, The fenced code block in the README.md
file that contains the ASCII diagram starting with "Editor (Zed, VS Code,
Neovim, …)" is missing a language identifier. Add the language identifier `text`
immediately after the opening triple backticks to specify that this is a
text-based ASCII diagram. This ensures proper rendering and linting compliance
for the markdown document.

Source: Linters/SAST tools

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@acp/README.md`:
- Line 140: The command examples in the README use the incorrect binary name
`acp` when the actual binary name defined in Cargo.toml is `iii-acp`. This
causes users to get "command not found" errors when they copy the examples.
Replace all occurrences of `acp` with `iii-acp` in the command examples shown in
the documentation. This includes the examples that demonstrate usage with flags
like `--use-canonical-brain` and `--model`. Ensure consistency across all
command examples so they match the correct binary name and align with the proper
reference shown elsewhere in the documentation.

---

Nitpick comments:
In `@acp/README.md`:
- Around line 35-43: The fenced code block in the README.md file that contains
the ASCII diagram starting with "Editor (Zed, VS Code, Neovim, …)" is missing a
language identifier. Add the language identifier `text` immediately after the
opening triple backticks to specify that this is a text-based ASCII diagram.
This ensures proper rendering and linting compliance for the markdown document.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6d5168fe-b854-4c94-9bba-676066457fad

📥 Commits

Reviewing files that changed from the base of the PR and between 5f220da and 2cfe57c.

⛔ Files ignored due to path filters (1)
  • acp/Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (7)
  • acp/Cargo.toml
  • acp/README.md
  • acp/iii.worker.yaml
  • acp/src/handler.rs
  • acp/src/main.rs
  • acp/src/session.rs
  • acp/tests/protocol.rs

Comment thread acp/README.md

```bash
iii-acp --use-canonical-brain --model claude-sonnet-4-5-20250929 --provider anthropic
acp --use-canonical-brain --model claude-sonnet-4-5-20250929 --provider anthropic

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Command examples use wrong binary name.

These examples show acp as the command, but the actual binary name in Cargo.toml line 22 is iii-acp. Users who copy these commands will get "command not found" errors. The binary reference at line 167 (/path/to/iii-acp) is correct.

Update these command examples to use iii-acp instead of acp.

📝 Proposed fix for command examples
-acp --use-canonical-brain --model claude-sonnet-4-5-20250929 --provider anthropic
+iii-acp --use-canonical-brain --model claude-sonnet-4-5-20250929 --provider anthropic

Apply the same change at lines 203 and 310.

Also applies to: 203-203, 310-310

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@acp/README.md` at line 140, The command examples in the README use the
incorrect binary name `acp` when the actual binary name defined in Cargo.toml is
`iii-acp`. This causes users to get "command not found" errors when they copy
the examples. Replace all occurrences of `acp` with `iii-acp` in the command
examples shown in the documentation. This includes the examples that demonstrate
usage with flags like `--use-canonical-brain` and `--model`. Ensure consistency
across all command examples so they match the correct binary name and align with
the proper reference shown elsewhere in the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant