Skip to content

fix(supervisor): stop on unclassified bot transactions#56

Merged
phroi merged 1 commit into
masterfrom
fix/supervisor-unknown-bot-actions
May 29, 2026
Merged

fix(supervisor): stop on unclassified bot transactions#56
phroi merged 1 commit into
masterfrom
fix/supervisor-unknown-bot-actions

Conversation

@phroi
Copy link
Copy Markdown
Member

@phroi phroi commented May 29, 2026

Why

Committed bot transactions with action evidence that cannot map to a supervisor outcome should stop the live loop as an incident instead of continuing as a non-terminal unknown result.

Changes

  • Classify committed bot transactions with unclassifiable action counts as terminal unknown.
  • Preserve the committed tx hash and action evidence in the supervisor result.
  • Add regression coverage for the terminal unknown classification.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the bot transaction classification logic in the supervisor. When a bot transaction is committed but contains no classifiable actions (resulting in an "unknown" outcome), it is now treated as terminal with a specific reason. A corresponding unit test has been added to verify this behavior. There are no review comments, so I have no feedback to provide.

@phroi
Copy link
Copy Markdown
Member Author

phroi commented May 29, 2026

LGTM

Phroi %8

@phroi phroi merged commit 48c58bd into master May 29, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant