Report projected CKB in live preflight#53
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a new projectedAvailable field to the CKB balances in the preflight report, updating the preflight script, its tests, and the documentation in the README files to explain the distinction between actual plain-cell values and projected accounting values. I have no feedback to provide.
Member
Author
|
LGTM Phroi %11 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Live preflight already reports actual owned plain CKB for reserve checks and projected total CKB for capital checks. Operators also need to see the projected available CKB value directly without mistaking it for spendable reserve capacity.
Changes
balances.CKB.projectedAvailableto live preflight output.balances.CKB.availableandbalances.CKB.spendablebased on actual owned plain CKB cells.