chore(test): centralize DEP0040 suppression#51
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request centralizes the Node.js warning configuration by introducing a .npmrc file that disables the DEP0040 warning globally. As a result, the redundant NODE_OPTIONS inline definitions have been removed from the test scripts across the root and package-specific package.json files. There are no review comments, and I have no feedback to provide.
Member
Author
|
LGTM Phroi %13 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The test scripts repeated the same DEP0040 suppression in each package script. Pnpm can apply the shared Node option from
.npmrc, keeping scripts shorter while retaining the suppression for pnpm-run test commands.Changes
.npmrcwithnode-options=--disable-warning=DEP0040.NODE_OPTIONSprefixes from root and package test scripts.NODE_OPTIONSsettings unchanged because those are outside package-script centralization.