Add aggregate_cdf to visualize CDF/CCDF of multiple archives - #722
Merged
Conversation
aggregate_cdf to visualize CDF of multiple archivesaggregate_histogram to visualize histogram and CDF/CCDF of multiple archives
aggregate_histogram to visualize histogram and CDF/CCDF of multiple archivesaggregate_cdf to visualize CDF/CCDF of multiple archives
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #126
TODO
ribs/visualize/__init__.pyribs/visualize/_aggregate_histogram.pytests/visualize/aggregate_histogram_test.pyQuestions
aggregate_cdforaggregate_histogram? At first, I named thisaggregate_histogram, as strictly speaking, the function is quite generic and can plot a histogram. However, given that archive histograms are uncommon in the literature (I have personally never seen one), I think we should emphasize the CDF/CCDF use case. Furthermore, histograms are already somewhat covered in thearchive_histogramfunction. Therefore, I decided to name the functionaggregate_cdfand setcumulative=Trueas the default. Users can passcumulative=-1to get a CCDF, andcumulative=Falseto get a histogram. Support for this will be included in the documentation, but it will not be emphasized as a use case.Status
CONTRIBUTING.md
ruffandpylintpytestHISTORY.md