Honor global --profile and --format flags in calendar commands#2
Open
jarvisluong wants to merge 2 commits into
Open
Honor global --profile and --format flags in calendar commands#2jarvisluong wants to merge 2 commits into
jarvisluong wants to merge 2 commits into
Conversation
Read global CLI options in calendar subcommands so profile selection and output format work consistently with the rest of gwcli. This prevents calendar commands from silently falling back to the default profile. Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Pull request overview
This PR updates the calendar CLI subcommands to consistently honor the global --profile and --format flags (matching behavior of other command groups), preventing calendar commands from unintentionally using the default profile/output format.
Changes:
- Read global CLI flags in calendar subcommands via
optsWithGlobals()rather than relying on subcommandoptions. - Wire
Commandinto calendar subcommand.action(...)callbacks to access parent/global options. - Align
package-lock.jsonpackage name withpackage.json, and ignoreclient_secrets/in.gitignore.
Reviewed changes
Copilot reviewed 1 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/commands/calendar.ts |
Uses optsWithGlobals() so calendar subcommands honor global --profile/--format. |
package-lock.json |
Updates lockfile package name to google-workspace-cli. |
.gitignore |
Adds client_secrets/ to prevent committing OAuth secrets. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| import type { GlobalOptions } from '../types/index.js'; | ||
|
|
||
| function getCalendarGlobalOptions(command: Command): GlobalOptions { | ||
| return command.parent?.optsWithGlobals() as GlobalOptions; |
…ned and recursive concerns Co-authored-by: jarvisluong <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Read global CLI options in calendar subcommands so profile selection and output
format work consistently with the rest of gwcli. This prevents calendar
commands from silently falling back to the default profile.
Co-authored-by: Copilot [email protected]