test(mcp-config): add --claude-code path tests#173
Open
kagura-agent wants to merge 1 commit into
Open
Conversation
Cover the writeClaudeCodeConfig function which was untested: - Creates settings.json when file does not exist - Merges into existing settings without overwriting other keys - Reports 'already configured' when memex entry exists - Idempotent — running twice does not duplicate config - Creates .claude directory if it does not exist
Contributor
Author
|
Hi 👋 Friendly check-in — this PR has been open for a week. Let me know if there's anything I should change or if this looks good to merge! |
Contributor
Author
|
Hi 👋 Friendly check-in — this PR has been open for a week. Would appreciate a review when you get a chance. Happy to adjust anything if needed. Thanks! 🙏 |
Contributor
Author
|
Hi 👋 Friendly check-in — this PR has been open for a week. Would appreciate any feedback or review when you have time. Happy to adjust if anything needs changing! |
Contributor
Author
|
Hi 👋 Friendly check-in — this PR has been open for over a week. Would appreciate any feedback when you have a moment. Happy to adjust if needed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add 5 test cases for the
--claude-codepath inconfigureMcp, which was previously untested.New Tests
.claude/dir and file created correctlymodel, othermcpServers)mkdir({ recursive: true })works for missing parent dirHow tested
Tests use a temp directory with
HOMEoverride to avoid touching the real~/.claude/settings.json.