fix(providers): emit explicit disabled thinking when required#228
Draft
GodfatherPacino wants to merge 1 commit into
Draft
fix(providers): emit explicit disabled thinking when required#228GodfatherPacino wants to merge 1 commit into
GodfatherPacino wants to merge 1 commit into
Conversation
This was referenced Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
emit_disabled_thinkingprovider compatibility optionthinking: { "type": "disabled" }on the Anthropic wire path when the option is enabledProblem
Some Anthropic-compatible gateways, including GLM-5.2 deployments, enable thinking by default. The runtime state could be switched to
disabled, but the Anthropic request projector omitted thethinkingfield forThinkingConfig::Disabled. The gateway therefore continued returning thinking content.GLM documents that disabling thinking requires an explicit
thinking.type = disabledrequest. The Anthropic Messages schema also defines a disabled thinking configuration, while some provider/model combinations still rely on omission or do not support disabling. A compatibility flag keeps that distinction configuration-driven.Verification
cargo fmt --allcargo clippy --workspace --all-targets -- -D warningscargo test -p aion-config compat_test(28 passed)cargo test -p aion-providers projector_test(27 passed)just pushgate, including nextest and cargo-hakari verificationReferences