fix(app): remove duplicate pre-parser mount of bypassRateLimit modules#1
Merged
Merged
Conversation
The bypassRateLimit modules (/api/posts, /api/admin/posts) and globalLimiter were each mounted twice — once BEFORE express.json() and once after. Express dispatches to the first match, so every posts write hit the pre-parser copy with req.body === undefined, causing validate() to throw "expected object, received undefined" (400) on PATCH/POST/DELETE while reads worked fine. Restore the single documented ordering: rawBody (auth) -> body parsers -> bypassRateLimit -> globalLimiter -> regular modules. This also moves the auth catch-all above the global limiter again (it had been double-counted against the per-IP limit). Verified against the live app: express.json (layer 8) now precedes the /api/posts (14) and /api/admin/posts (15) routers, with auth (7) above the parser. Co-Authored-By: Claude Opus 4.8 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bypassRateLimit modules (/api/posts, /api/admin/posts) and globalLimiter were each mounted twice — once BEFORE express.json() and once after. Express dispatches to the first match, so every posts write hit the pre-parser copy with req.body === undefined, causing validate() to throw "expected object, received undefined" (400) on PATCH/POST/DELETE while reads worked fine.
Restore the single documented ordering: rawBody (auth) -> body parsers ->
bypassRateLimit -> globalLimiter -> regular modules. This also moves the auth catch-all above the global limiter again (it had been double-counted against the per-IP limit).
Verified against the live app: express.json (layer 8) now precedes the /api/posts (14) and /api/admin/posts (15) routers, with auth (7) above the parser.