This repository was archived by the owner on Jan 22, 2020. It is now read-only.
Server will now only try to send one response for per request#43
Open
mpmckenna8 wants to merge 1 commit into
Open
Server will now only try to send one response for per request#43mpmckenna8 wants to merge 1 commit into
mpmckenna8 wants to merge 1 commit into
Conversation
… and will no longer log or catch errors from trying to rewrite headers. Basically every response gets a res_msg which is a string onto which either errors are appended, or if succesful the tx code is added and sent, showing the client it worked. An alternative would be to use res.write to keep adding stuff to the response. Signed-off-by: mpmckenna8 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Server logic in controller.js will no longer log or catch errors from trying to rewrite headers. Basically every response gets a res_msg which is a string onto which either errors are appended, or if succesful the tx code is added and sent, showing the client it worked. An alternative would be to use res.write to keep adding stuff to the response.
addresses #40
Signed-off-by: mpmckenna8 [email protected]