Provider-owned startup#880
Merged
Merged
Conversation
e5284f7 to
0e3a152
Compare
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Collaborator
Author
|
Required by #841 |
sergiopaniego
left a comment
Member
There was a problem hiding this comment.
thanks! some comments from review:
Two that have no line to anchor inline:
- Docs.
docs/source/guides/runtime-providers.mdstill shows only the old manual flow (provider.start_container(image)+wait_for_ready+MyEnv(base_url=..., provider=...)). It should show the newMyEnv(provider=provider)form and documentnew_session()(including that it can fail atMAX_CONCURRENT_ENVScapacity and that its lifecycle is owned by the parent). - Coordination with #841. Both PRs modify
env_client.py's provider plumbing independently and are not stacked, so there is a conflict to reconcile. Merging #880 first and rebasing #841 on top is the cleanest order, since #841 already dropped its ownnew_sessionexpecting this PR to provide it.
ac5465a to
0403170
Compare
Collaborator
Author
|
Thanks, addressed the review in 0403170.
Agreed on #841: #880 should land first, then #841 can rebase on top and use the shared provider/session plumbing from this PR. |
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR lets EnvClient start providers that own their image/source, so that Daytona and Modal are consistent with HFSandbox and this improved DX: