Skip to content

fix(eval): reject empty task slugs - #522

Merged
jdchawla29 merged 1 commit into
mainfrom
codex/trace-slug-validation
Jul 31, 2026
Merged

fix(eval): reject empty task slugs#522
jdchawla29 merged 1 commit into
mainfrom
codex/trace-slug-validation

Conversation

@jdchawla29

@jdchawla29 jdchawla29 commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • require explicit task slugs to contain at least one character
  • add coverage for rejecting slug=""

Why

The SDK reports Task.slug directly to trace and rollout endpoints.

Impact

Default slug generation is unchanged. Explicit empty slugs now fail immediately during Task construction with the same Pydantic validation used for empty environment names and task IDs.

Validation

  • uv run '--with=.[dev]' pytest hud/eval/tests/test_task.py (18 passed)
  • uv run '--with=.[dev]' ruff check hud/eval/task.py hud/eval/tests/test_task.py
  • uv run '--with=.[dev]' pyright hud/eval/task.py

Note

Cursor Bugbot is generating a summary for commit a1a7717. Configure here.

@jdchawla29
jdchawla29 marked this pull request as ready for review July 31, 2026 00:01

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a1a7717f83

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread hud/eval/task.py
@jdchawla29
jdchawla29 merged commit 0214b3a into main Jul 31, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant