fix(eval): report task slugs with traces - #521
Merged
Merged
Conversation
jdchawla29
marked this pull request as ready for review
July 30, 2026 22:05
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 556fe6d287
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 556fe6d. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Task.slugduring Pydantic validation, deriving a stable default from task id and args when omittedtask_slugin the trace-enter report for local and cloud executionWhy
The trace reporting boundary carried execution identifiers but omitted logical task identity. Unlinked SDK traces therefore reached the platform with no stable task key and fell back to UUID-derived labels or
Unknown Task.This makes
task_slugthe portable task identity across execution environments while leavinggroup_idas execution-group identity. The model now guarantees that every validTaskhas a slug, so consumers do not need independent fallback logic.Validation
uv run pytest -p no:cacheprovider hud/eval/tests/test_task.py hud/eval/tests/test_job.py hud/eval/tests/test_hosted.py— 37 passeduv run pyright— 0 errorsuv run ruff checkon changed filesuv run ruff formaton changed filesuv lock --checkNote
Medium Risk
Changes wire contracts (
task_slugon trace enter,slugon rollout submit) and make slug required on all tasks; platform must accept new fields, and older pydantic or clients assuming optional slug may need updates.Overview
Every valid
Tasknow has a materializedslugat validation time (stable default from task id plus args hash when omitted), replacing optionalslugand removeddefault_slug()fallbacks across the eval stack.Platform and local reporting send logical task identity:
trace_enterincludestask_slug, hosted/rollouts/submitaddsslug, and taskset upload/sync/Harbor export usetask.slugdirectly for names and run receipts.Dependency:
pydanticminimum raised to 2.10 inpyproject.toml. Tests cover default/explicit/invalid slugs and both trace-enter and hosted submit payloads.Reviewed by Cursor Bugbot for commit 556fe6d. Bugbot is set up for automated code reviews on this repo. Configure here.