Project goal-scoped agent task visibility#2549
Conversation
|
Maintainer self-review
|
|
CI follow-up GitHub |
huangruiteng
left a comment
There was a problem hiding this comment.
Independent review result: approve merge. No blocking findings at exact head 86fde0c40637c6df5d90a45cffd6d9dc29a61755.
Findings
No blocking correctness, authority, compatibility, or boundary issue found.
Non-blocking budget note: the quota hot-path fixture is now 12547/12550 JSON characters. This PR does not raise the threshold and uses one compact enum instead of a wide duplicate object, so I do not consider it a merge blocker. The next quota hot-path addition will need to remove or compact existing output rather than append another field.
Product and architecture judgment
The change closes a real agent-facing ambiguity without changing todo selection. Agent-scoped quota decisions now carry one versioned task_scope; current-agent and eligible unclaimed items remain executable candidates, other-agent claims remain diagnostic, and an unclaimed selection still carries claim_required_before_work=true. The same enum is retained in TurnEnvelope.contract_capsule, so host handoff does not lose the boundary. Cross-goal candidate authority is unchanged; the docs correctly reserve cross-goal visibility for explicit read-only global-manager inventory.
The diff shape is proportionate: 20 net production lines, 18 documentation lines, and 86 focused test lines. The private helper has one caller, but keeping the enum attachment in the agent-scope owner is reasonable and avoids duplicating contract knowledge in quota assembly. I found no safe reduction that would preserve ownership and validation more clearly.
Validation
- GitHub
pytest: success. 10 passedfor the new visibility tests plus adjacent agent-scope regressions.- Hot-path interface budget smoke: pass, including quota
12547/12550. - Work-lane contract and agent-scope/work-lane consistency smokes: pass.
- Changed-file
py_compile, Ruff, andgit diff --check: pass. - Remote head read back unchanged before verdict.
Merge decision
Approved for merge. This is an additive control-plane contract projection with focused negative boundaries; it does not alter routing, permissions, benchmark behavior, production actions, or persisted state.
|
Maintainer exact-head review: no blocking findings at FindingsNo correctness, compatibility, execution-authority, or public/private-boundary blocker found. Non-blocking constraint: the quota hot-path fixture is Product and architecture judgmentThe projection makes visibility explicit without changing todo selection or permission. A registered peer can read ordinary work in the current goal, execute only its own claimed or eligible unclaimed candidate, and must claim an unclaimed selection before work. Other-agent claims remain diagnostic. The versioned The diff is proportionate: one compact enum attached by the existing agent-scope owner, one TurnEnvelope retention field, focused tests, and canonical documentation. This avoids a duplicate wide object and keeps task authority in existing selection code. Validation
Merge decisionApproved for the user's explicitly authorized maintainer self-merge after #2548, with exact-head protection. The combined post-merge state has been validated. |
Summary
task_scopeon agent-scoped quota decisionsValidation
loopx canary premerge --from-git-diff --tier standard: 18/18 selected checks passedBoundaries