feat(sql): semantic tokens for db blocks via the SQL grammar#33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 2 of SQL support: the language server now emits semantic highlight
tokens for
db-*blocks by walking the SQL CST (Phase 1 grammar).Semantic_tokens.kinds:Sql_keyword/Sql_identifier/Sql_string/Sql_number/Sql_comment.sql_tokenswalks the CST and colours only leaf nodes (keyword_*,identifier, string/number literals, comments); structural nodes are
skipped so tokens never overlap. Ref spans are carved out like HTTP does.
body_tokensdispatches by fence lang:http-> HTTP tokens,db-*->SQL tokens.
type_indexextended; SQL kinds downgrade to the standardLSP token types (keyword/variable/string/number/comment).
absolute offsets, http emits no sql tokens); adjusted 2 protocol tests
whose legend indices shifted. 140 pass, 0 fail.
No desktop change yet (the desktop keeps its lang-sql first-paint); wiring
the LSP SQL tokens into CM6 lands with a later release.