Environment variable names in completion and hover#12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The server accepts
--db <path>(the app's SQLite database) and enriches completion and hover with the variable names of the active environment. Completion inside{{now offers block aliases plus env keys (secret ones labeled); hovering a bare{{KEY}}that matches an active-environment variable says so, with a secret note when applicable.Privacy invariant
The server reads
keyandis_secretonly — nevervalue, secret or not. Values belong to the execution path; this process has no keychain access by design and now provably never selects the value column either.Implementation
bin/env_store.ml: lazy read-only caqti connection, one query per request (reads measured in the tens of microseconds; the active environment can change while the server runs, so no caching). Missing--dbor a failed read degrades to the previous behavior.Analyze.completion_at/hover_attake the env names as input data, keeping the library pure — the IO shell supplies them.Tests
48 checks. New: completion appends env keys with the secret flag, hover marks a secret env var, and a third integration session spawns the binary with
--dbpointing at a fixture database created by the test (schema mirroring the app'senvironments/env_variables), asserting env keys and the secret detail arrive over the protocol.