feat(core): local crash-log file store#3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a small file-backed crash-log store under
<data_dir>/crashes,shared by the desktop panic hook and the language server's top-level
exception handler. Plain-text files, never uploaded; the desktop
"Crashes" settings panel reads them back.
crashes_dir()→<data_dir>/crasheswrite_crash(dir, source, body)— panic-safe, best-effort, returns thefile name (
<epoch_ms>-<source>.log); sanitizes the source tag so itcan't inject a path separator
list_crashes(dir)— newest-first metadata (name, source, epoch_ms,first-line summary); skips malformed names; missing dir → empty
read_crash(dir, name)— rejects path traversal (bare file name only)clear_crashes(dir)— removes only.logfiles; missing dir is a no-op