-
Notifications
You must be signed in to change notification settings - Fork 0
feat: 베타 채널 별도 항목 Chrome Web Store 자동배포 골격 #113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
6-keem
wants to merge
1
commit into
main
Choose a base branch
from
feat/112-beta-store-publish
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
빈
BETA_CLIENT_ID로 인해 모든 베타 빌드의 OAuth 가 동작하지 않습니다.isBeta인 빌드에서는clientId가 빈 문자열(BETA_CLIENT_ID = '')로 설정되어oauth2.client_id가 비게 됩니다(Line 18 → Line 56). 베타 빌드 스텝(RELEASE_CHANNEL=beta)은ENABLE_STORE_PUBLISH게이트와 무관하게 항상 실행되어 그 산출물이 프리릴리즈 zip 으로 첨부되므로, 베타 테스터가 받는 빌드는chrome.identity토큰 검증이 실패하거나 매니페스트 로드 자체가 거부될 수 있습니다.#112로 발급받은 실제client_id로 교체되기 전까지는 베타 산출물이 배포되지 않도록 하거나, 빈 값일 때 빌드를 명시적으로 실패시키는 가드를 두는 것을 권장합니다.BETA_CLIENT_ID가 비어 있을 때 베타 빌드를 조기에 실패시키는 가드를 추가하는 변경을 원하시면 도와드리거나,#112추적을 위한 이슈 정리를 도와드릴까요?🤖 Prompt for AI Agents