Stop passing deprecated $message to V3 variables in Horde_Form::validate()#34
Open
TDannhauer wants to merge 1 commit into
Open
Stop passing deprecated $message to V3 variables in Horde_Form::validate()#34TDannhauer wants to merge 1 commit into
TDannhauer wants to merge 1 commit into
Conversation
Contributor
Author
|
pls review whether this approach is viable @ralflang . turba floods the logs with this issue |
Member
|
We should really finish migration to V3 in other apps first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Horde_Formvalidates forms that use V3 variables created byHorde_Form::createVariable().Horde_Form::validate()no longer passes the deprecated second$messageargument to V3BaseVariableinstances; it is still passed for legacyHorde_Form_Variablewrappers (e.g. app-specific types without a V3 class).Horde\Form\V3\BaseForm::validate(), which already calls$var->validate($vars)with a single argument.Problem
Horde_Form::createVariable()now returns V3 variables (e.g.Horde\Form\V3\TextVariable) when a modern class exists. LegacyHorde_Form::validate()still called: