Horde_Form and V3 fixes#26
Merged
Merged
Conversation
ralflang
requested changes
Apr 24, 2026
- use getFieldParts() instead of getArrayParts() in 'image' type - utilize extra parameter in getElement/setElement to simplify the code - make getUploadedFileType() static
Member
Author
|
Added more changes. |
Member
Author
|
any comments? |
Contributor
|
applied locally in my instance and Horde works normally. I suggest to merge it in and move forward from that. |
TDannhauer
approved these changes
May 5, 2026
Contributor
TDannhauer
left a comment
TDannhauer
left a comment
There was a problem hiding this comment.
tested locally. no visibly hickups, but no deeper tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.