docs: correct outbox claim timing back to in-transaction#73
Conversation
The PR #53 review (6885393) reworded the with_bus outbox path to say the row is claimed *post-commit*. That described OutboxDispatcher::dispatch_ids — a separate primitive used only by transport conformance tests. The actual with_bus path (AggregateCommit::commit) claims each row in the commit transaction via claim_at before commit_batch writes it (born InFlight under a short lease), then publishes via publish_claimed after commit. Restore the accurate in-transaction wording in the README and the with_bus doc comment. Implements [[tasks/distributed-tooling-crate-extraction]] Co-Authored-By: Claude Opus 4.8 <[email protected]>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughDocumentation updates clarify the outbox pattern's bus-attached publishing sequence. The README and ChangesOutbox pattern claiming and publishing sequence
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Reverts a doc-wording change from the PR #53 review (commit
6885393) that was based on a misread of the code paths.The review comment pointed at
OutboxDispatcher::dispatch_ids(which claims rows post-commit viaclaim_async) and concluded the README's "claims the row in the commit transaction" wording was wrong. Butdispatch_idsis used only bytests/transport_conformance/— never byService::with_bus.The actual
with_busimmediate-publish path isAggregateCommit::commit(src/outbox/commit.rs):claim_at(...)mutates each outbox message toInFlightunder a short lease (commit.rs:161)commit_batchpersists those rows in the transaction (commit.rs:173)publish_claimed(...)publishes immediately after commit (commit.rs:187)So rows are genuinely born
InFlightin the commit transaction. The original wording was correct; this restores it in the README and thewith_busdoc comment. Code behavior is unchanged — docs only.Test output
cargo build --libclean (doc-comment + README only).Summary by CodeRabbit