chore: remove hello-world step from getting started tutorial#644
chore: remove hello-world step from getting started tutorial#644pdaoust wants to merge 4 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (6)
📒 Files selected for processing (15)
💤 Files with no reviewable changes (1)
✅ Files skipped from review due to trivial changes (10)
WalkthroughThis PR removes the Hello World tutorial, promotes the Forum App tutorial as the primary Get Started path, updates navigation and Netlify routing/checklinks configuration, expands and revises the Forum App tutorial with working directory setup, project layout explanation, AppArmor-based Ubuntu 24.04 dev-mode fix, updated screenshots, and adjusted button markup, and updates internal cross-reference links across build, resource, and upgrade documentation to the renumbered tutorial paths. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@netlify.toml`:
- Around line 103-111: The two redirect blocks currently map each path to itself
(/get-started/2-forum-app-tutorial/ and
/get-started/3-packaging-and-distribution/); update the redirects so the from
fields are the legacy/old URLs you intend to replace and the to fields point to
the new destination pages (or delete these redundant blocks if no redirect is
needed), e.g., modify the [[redirects]] entries referencing
"/get-started/2-forum-app-tutorial/" and
"/get-started/3-packaging-and-distribution/" so they do not have identical from
and to values.
In `@src/pages/get-started/2-forum-app-tutorial.md`:
- Line 853: Replace the non-descriptive link text "[here]" in the sentence "You
can find out more
[here](/get-started/install-advanced/#fixing-the-suid-sandbox-error-in-ubuntu-24-04-and-later)."
with a descriptive phrase such as "in the advanced install guide section on
fixing the SUID sandbox error" so the link reads: "You can find out more in the
advanced install guide section on fixing the SUID sandbox error." This change
should be made where that sentence appears in the get-started tutorial content
(the line containing the existing [here] link).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: a46553f3-c0f6-47d9-b781-627d94d8128f
⛔ Files ignored due to path filters (6)
src/assets/img/get-started/2-look-for-hellos.pngis excluded by!**/*.pngsrc/assets/img/get-started/2-two-uis.pngis excluded by!**/*.pngsrc/assets/img/get-started/3-no-posts-found.pngis excluded by!**/*.pngsrc/assets/img/get-started/4-create-post-component.pngis excluded by!**/*.pngsrc/assets/img/get-started/5-edit-post.pngis excluded by!**/*.pngsrc/assets/img/get-started/6-comment-components.pngis excluded by!**/*.png
📒 Files selected for processing (15)
netlify.tomlsrc/pages/_data/navigation/mainNav.json5src/pages/build/application-structure.mdsrc/pages/build/connecting-a-front-end.mdsrc/pages/build/dht-operations.mdsrc/pages/build/happs.mdsrc/pages/build/validate-callback.mdsrc/pages/build/validation.mdsrc/pages/build/zomes.mdsrc/pages/get-started/2-forum-app-tutorial.mdsrc/pages/get-started/2-hello-world.mdsrc/pages/get-started/3-packaging-and-distribution.mdsrc/pages/get-started/index.mdsrc/pages/resources/compatibility/index.mdsrc/pages/resources/upgrade/upgrade-holochain-0.5.md
💤 Files with no reviewable changes (1)
- src/pages/get-started/2-hello-world.md
|
Actionable comments posted: 0 |
jost-s
left a comment
There was a problem hiding this comment.
Looks great! Just one change requested regarding the UI framework selection.
80a318a to
244da7f
Compare
|
✔️ a938e57...244da7f - Conventional commits check succeeded. |
|
NOTE: this PR is ready to go, but we won't deploy it until Holochain 0.7 is the recommended version, because the changes to the scaffolding tool won't apply until then.
Things I did:
Closes #631