Skip to content

Service centres parent branch (DO NOT MERGE)#276

Draft
josh-uk wants to merge 6 commits into
masterfrom
service-centres
Draft

Service centres parent branch (DO NOT MERGE)#276
josh-uk wants to merge 6 commits into
masterfrom
service-centres

Conversation

@josh-uk

@josh-uk josh-uk commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

JIRA link

FACT-2618 + others (refer to board)

Change description

Parent branch for service centres work.

Does this PR require manual testing? (check one with "x")

[x] Yes
[ ] No

Does this PR introduce a breaking change? (check one with "x")

[x] Yes
[] No

josh-uk added 4 commits June 17, 2026 14:49
Remove old service centre code
* Add service centre entities and update audit

* jsonignore
* Added new controllers/services for service centres

* Func test fixsxes

* Clean up and splitting
Comment on lines +79 to +81
return ResponseEntity.status(HttpStatus.OK)
.body(serviceCentreService.deleteServiceCentresByNamePrefix(serviceCentreNamePrefix)
+ " service centre(s) with prefix " + serviceCentreNamePrefix + " deleted successfully");
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
D Security Rating on New Code (required ≥ A)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@Parameter(description = "UUID of the service centre", required = true)
@ValidUUID @PathVariable String serviceCentreId,
@Parameter(description = "AreasOfLaw object to create or update", required = true)
@Valid @RequestBody ServiceCentreAreasOfLaw serviceCentreAreasOfLaw) {
@Parameter(description = "UUID of the service centre", required = true)
@ValidUUID @PathVariable String serviceCentreId,
@Parameter(description = "Contact detail to create", required = true)
@Valid @RequestBody ServiceCentreContactDetails serviceCentreContactDetails
@ValidUUID @PathVariable String serviceCentreId,
@Parameter(description = "UUID of the contact", required = true) @ValidUUID @PathVariable String contactId,
@Parameter(description = "Updated contact detail", required = true)
@Valid @RequestBody ServiceCentreContactDetails serviceCentreContactDetails
* Added details endpoints/view

* fix func
@github-actions

github-actions Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

⚠️ Flyway Duplicate Version Check Failed

Duplicate version(s) detected:

V1.27 (exists in master)
V1.28 (exists in master)
V1.29 (exists in master)
V1.30 (exists in master)

Please ensure all Flyway migration version numbers are unique.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants