feat: add vitest-given package#25
Conversation
jsaguet
force-pushed
the
vitest-given
branch
from
660e9a8 to
3be1834
Compare
jsaguet
force-pushed
the
vitest-given
branch
from
3be1834 to
f02b0e6
Compare
jsaguet
force-pushed
the
vitest-given
branch
from
f02b0e6 to
427fe0b
Compare
jsaguet
force-pushed
the
vitest-given
branch
from
427fe0b to
c60a45e
Compare
|
thanks @jsaguet just updated the repo, please fix the conflicts and let's get it merged |
🦋 Changeset detectedLatest commit: 3c1cba7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jsaguet
force-pushed
the
vitest-given
branch
3 times, most recently
from
ee702c2 to
b22a2b7
Compare
|
@shairez I've rebased the PR and have made a few adjustments. The CI is failing regarding I've generated a chanset to major bump vitest given, let me know if that was the correct thing to do since it would be the first release of the vitest package. |
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| '@hirez_io/vitest-given': major | |||
There was a problem hiding this comment.
I don't think you should remove, I think you should just change to "minor" because it's a feature, just not a breaking one
There was a problem hiding this comment.
(pay attention that I've committed and pushed a fix to the CI for now, so don't force push your change or it'll mess up stuff)
| "peerDependencies": { | ||
| "vitest": "^4.0.0" | ||
| }, | ||
| "devDependencies": { |
There was a problem hiding this comment.
please move the depDependencies to the root
commit: |
|
OK I've added a temp fix for now, seems to be working we do need the changeset file for it to be released, just put it on minor please (and you can edit the MD file to explain how to install or point to the README so it'll get into the release notes) |
jsaguet
force-pushed
the
vitest-given
branch
2 times, most recently
from
5f448ca to
76161c6
Compare
|
Thanks ! Is this changeset ok ? |
| '@hirez_io/vitest-given': minor | ||
| --- | ||
|
|
||
| Add @hirez_io/vitest-given package |
There was a problem hiding this comment.
| Add @hirez_io/vitest-given package | |
| FEAT: Add `@hirez_io/vitest-given` package |
|
|
||
| Add @hirez_io/vitest-given package | ||
|
|
||
| See the package README for installation instructions. |
There was a problem hiding this comment.
| See the package README for installation instructions. | |
| See the [installation instructions](https://github.com/hirezio/given/tree/master/packages/vitest-given). |
thanks, added suggestions |
|
Thanks @jsaguet ! |
|
vitest-given has just been released 🎉 @all-contributors please add @jsaguet for code, maintenance |
|
I've put up a pull request to add @jsaguet! 🎉 |
2 participants
This PR adds a new package
vitest-giventhat is compatible withvitest.This is a requirement to add support for
vitesttoauto-spies.