test262: Symbol conformance fixes (wave 13) - #72
Merged
Conversation
Explicit Resource Management (ES2026) defines two additional well-known Symbols, @@dispose and @@asyncDispose. Like the other well-known symbols in this compiler they need to EXIST as fixed unique values: typeof each is "symbol", each is === only to itself, and none are registered in the global symbol registry, so Symbol.keyFor returns undefined for them. Fixes test262 built-ins/Symbol/{dispose,asyncDispose}/no-key.js.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recognizes the two Explicit Resource Management (ES2026) well-known Symbols,
Symbol.disposeandSymbol.asyncDispose, as fixed unique Symbol values (§ well-known symbols table). Each has typeof "symbol", is === only to itself, is distinct from other well-known symbols, and is absent from the global registry soSymbol.keyForreturns undefined.Fixes test262
built-ins/Symbol/dispose/no-key.jsandbuilt-ins/Symbol/asyncDispose/no-key.js(Symbol suite pass 14 -> 16).The rest of the reachable Symbol residual is boundary-gated (symbol-keyed property store / Symbol wrapper objects — the documented v1 boundary; Object.defineProperty/getOwnPropertyDescriptor/getPrototypeOf tarpits; $262 cross-realm; and
.callreceiver-forwarding on a stored unbound prototype method, which needs the shared func_call helper).