Add config option to opt-out of generated query serializer#3749
Add config option to opt-out of generated query serializer#3749cappuc wants to merge 5 commits intohey-api:mainfrom
Conversation
|
|
|
Reviewed PR #3749. The core Task list (5/5 completed)
|
|
@cappuc is attempting to deploy a commit to the Hey API Team on Vercel. A member of the Team first needs to authorize it. |
|
|
TL;DR — Adds a Key changes
Summary | 87 files | 5 commits | base:
When
|
There was a problem hiding this comment.
Important
The core feature (guarding query serializer generation behind plugin.config.querySerializer) is correct and well-tested. However, the diff includes a large unrelated reordering of properties in types.ts that makes the PR harder to review and introduces ordering issues. Please revert the property shuffling and keep only the querySerializer additions.
Task list (5/5 completed)
- Read the diff to identify major areas of change
- Read non-snapshot source changes in detail
- Investigate correctness, config type, and code generation logic
- Verify test coverage and snapshot correctness
- Submit review
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3749 +/- ##
=======================================
Coverage 40.04% 40.04%
=======================================
Files 520 520
Lines 19243 19244 +1
Branches 5726 5727 +1
=======================================
+ Hits 7705 7706 +1
Misses 9342 9342
Partials 2196 2196
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@hey-api/codegen-core
@hey-api/json-schema-ref-parser
@hey-api/nuxt
@hey-api/openapi-ts
@hey-api/shared
@hey-api/spec-types
@hey-api/types
@hey-api/vite-plugin
commit: |

Fix #3747
This PR adds a config option to disable the generated
querySerializerobject in sdk functions.The generated
querySerializeroverrides the clientquerySerializerso it doen't allow to handle the serialization globally.