Add unsafe/debug hygiene ast-grep rules#2153
Merged
Merged
Conversation
Three validated rules under rules/rust/hygiene/: - `unsafe-without-safety` (warning): flag `unsafe` blocks lacking a `// SAFETY:` justification. The convention is near-universal (3659/3713 non-test unsafe blocks carry one), so this surfaces the 54 genuine gaps, not the convention. - `transmute-audit` (hint): inventory the 10 `mem::transmute` call sites for layout/lifetime review — the most dangerous unsafe operation. - `dbg-macro` (warning): preventive guard against shipping `dbg!`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three validated hygiene rules added to the ast-grep set (
rules/rust/hygiene/):unsafe-without-safety(warning, 54) — flagsunsafe { … }blocks without a// SAFETY:justification. The repo convention is near-universal — 3659/3713 non-testunsafeblocks (98.5%) already carry one — so the rule surfaces the 54 genuine gaps, not the convention. (A naive matcher gave 1328; the SAFETY-adjacency logic across every placement variant cut it to 54 with zero false negatives.)transmute-audit(hint, 10) — inventory ofmem::transmute(…)/transmute::<…>(…)sites for layout/lifetime review.dbg-macro(warning, 0) — preventive guard against shippingdbg!.Verification
scripts/ast-grep-lint.shruns the full set (now 15 rules) with no load errors.rules/rust/hygiene/_REPORT.md.unsafe-without-safety/transmute-auditreport as warning/hint;dbg-macrois empty today).