Add banGroupUsers function (#84) - #205
Merged
Merged
Conversation
|
|
mofirouz
reviewed
Jul 3, 2026
| std::function<void()> successCallback, | ||
| ErrorCallback errorCallback) { | ||
| try { | ||
| NLOG_INFO("..."); |
Member
There was a problem hiding this comment.
Thanks for the contribution. This is probably leftover from your testing :)
Contributor
Author
There was a problem hiding this comment.
Thanks, that was carried over from the kick method. Removed it and pushed.
VBorisof
approved these changes
Jul 7, 2026
VBorisof
left a comment
VBorisof
left a comment
Contributor
There was a problem hiding this comment.
Looks great, thank you for the contribution! 🙂
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #84.
Adds the missing
banGroupUsersclient function, which was present in the other Nakama SDKs (Go, JS, .NET) but absent from the C++ client.Implementation
kickGroupUserspattern acrossNClientInterface.h,BaseClient(async wrapper), andRestClient(REST implementation)./v2/group/{groupId}/ban, matching the server endpoint and the other SDKs.test_addAndBanGroupUser) intest_groups.cpp, registered intest_groups(), similar totest_addAndKickGroupUser.Note on gRPC
REST client only for now. I noticed
sessionLogoutis also REST-only, so I followed that since the gRPC version would need aBanGroupUsersRequesttype and anAsyncBanGroupUsersstub, and neither is in the generated API yet. Can extend to gRPC if you want the API definitions regenerated.Testing
The change compiles cleanly on Windows (win-x64, MSVC). I haven't run the integration suite locally as it requires a running server, but the test mirrors the existing
kickGroupUserscoverage and is ready for CI.