docs(gha): correct status-emoji description and document per-run comment reset#49
Merged
Merged
Conversation
Two behavioral corrections from hephbuild/heph#129: 1. The heading emoji is now driven by the invocation's stream lifecycle (closed = done), not by "every matched target finished." The old phrasing was wrong for transparent-group targets that never emit ResultEnd — the emoji is now ✅ when the command exits, not when done == total. 2. Each new workflow run (GITHUB_RUN_ID + GITHUB_RUN_ATTEMPT) resets the comment's sections. The previous "reused across reruns, never duplicated" text didn't capture this: stale sections from a prior build are now cleared when the first step of a new run writes.
⚡ Cloudflare Pages preview
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two documentation corrections for the GitHub Actions plugin page, following the bug fixes in hephbuild/heph#129.
Changes
Status emoji description (
## What the comment looks like)The old text said ✅ appears "once every matched target finishes without error." That was wrong — the emoji is now driven by the invocation's stream lifecycle (the command exiting), not by a
done == totalcount. Transparent group targets never emitResultEnd, so the count-based signal left the emoji stuck on ⏳ after the build finished. Updated to: "✅ once the command finishes without error."Per-run comment reset (
## One comment per job, one section per step)The old text said the comment is "reused across reruns, never duplicated," but didn't describe what happens to stale sections from a prior build. A new workflow run (identified by
GITHUB_RUN_ID+GITHUB_RUN_ATTEMPT) now resets the comment body — the previous build's sections are cleared when the first step of the new run writes. Added a paragraph explaining this so users understand why the comment shows only the current run's output.Source
hephbuild/heph#129 —
fix(plugin-gha): reset comment per run + tie status emoji to invocation lifecycleGenerated by Claude Code