You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR delivers a significant upgrade to both the product and development infrastructure. It overhauls the analytics dashboard with modern charts and reorganized components while simultaneously standardizing the development environment with updated Docker configurations, CI pipelines, and linting rules.
Major Changes
Analytics Dashboard Overhaul:
New hierarchical prize pyramid charts.
Improved data dispersion and dispersion-by-decade visualizations.
Reorganized component structure for better maintainability.
Infrastructure & Tooling Upgrade:
Standardized devcontainer and Docker health checks.
Enhanced GitHub Actions CI workflows.
Strict linting and formatting rules integration.
Comprehensive workspace template updates.
Bug Fixes & Refinements (from Code Review)
Fixed potential memory leaks in the search worker client.
Corrected race conditions in seeding state logic during data source switching.
Standardized React type imports across UI components.
Fixed localization inconsistencies in analytics charts.
Replaced magic numbers with shared constants for mathematical consistency.
Removed dead code and updated misleading documentation.
Type of change
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
How has this been tested?
Changes were verified via static analysis, type checking, and manual review of the analytics components.
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR refactors the app into a more modular, feature-oriented architecture (analytics/search/generator) with worker-based heavy computations, while also adding a standardized dev environment (devcontainer + Docker), stricter linting, CI E2E steps, and basic SEO/PWA assets.
Changes:
Introduces new Zustand store layer (lottery, analytics, data source) and cross-store orchestration via AppProvider.
Moves analytics/search computations into Web Workers with shared worker client infrastructure.
Adds/updates developer tooling and ops assets: devcontainer, docker-compose, ESLint+Prettier config, CI Playwright steps, sitemap/robots/manifest.
Reviewed changes
Copilot reviewed 274 out of 298 changed files in this pull request and generated 13 comments.
Show a summary per file
File
Description
tests/fixtures/real-data.ts
Removes Excel-backed real-data fixture.
tests/example.test.ts
Removes placeholder Vitest test.
tests/e2e/test-results/.last-run.json
Removes committed Playwright run artifact.
tests/e2e/dashboard.spec.ts
Removes dashboard E2E spec.
src/store/selectors.ts
Adds global selector façade across stores.
src/store/lottery.ts
Adds new lottery dataset store (init + file upload).
src/store/data.ts
Adds data source switching (official/local) + IDB integration.
src/shared/utils/motion.ts
Centralizes motion presets and tooltip style.
src/shared/utils/feedback.ts
Adds haptic/audio feedback utility.
src/shared/utils/download.ts
Adds browser JSON download helper.
src/shared/utils/cn.ts
Adds Tailwind class merge helper in shared layer.
src/shared/utils/ballColors.ts
Adds frequency→color gradient utility.
src/shared/hooks/useToast.ts
Adds lightweight toast state hook.
src/shared/constants/chart-colors.ts
Adds shared chart palette + dimensions.
src/shared/components/ui/Toast.tsx
Adds toast UI + container.
src/shared/components/ui/Skeleton.tsx
Adds skeleton loading component.
src/shared/components/ui/Card.tsx
Adds Card UI primitives in shared layer.
src/shared/components/ui/Button.variants.ts
Adds CVA-based button variants.
src/shared/components/ui/Button.tsx
Adds enhanced shared Button component.
src/shared/components/StatCard.variants.ts
Adds StatCard variants + styles.
src/shared/components/StatCard.tsx
Adds shared StatCard molecule.
src/shared/components/LoadingBalls.tsx
Updates loading indicator styling/docs.
src/shared/components/ErrorBoundary.tsx
Adds global React error boundary UI.
src/shared/components/AnimatedCounter.tsx
Adds shared animated counter component.
src/pages/NotFound.tsx
Removes old NotFound page (migrated routing).
src/pages/Index.tsx
Removes old Index page (migrated to feature page).
src/pages/About.tsx
Removes old About page (migrated to feature page).
src/main.tsx
Moves entrypoint under src/app/main.tsx.
src/lib/zustand.ts
Adds store factory helpers (devtools/subscribe/persist).
src/lib/worker-client.ts
Adds generic promise-based worker client.
src/lib/utils.ts
Removes old cn helper (relocated).
src/lib/lotteryIdb.ts
Adds IndexedDB persistence wrapper for large datasets.
henriquebonfim
changed the title
Overhaul analytics dashboard with new charts and reorganized components
feat: overhaul analytics dashboard and upgrade dev infrastructure
Apr 7, 2026
This massive PR (298 files) successfully upgrades the project infrastructure (Docker, CI) and delivers significant analytics dashboard enhancements. Build and Typecheck pass successfully.
However, there are critical gaps in testing: the repository has zero unit tests in src/, making this a large-scale change with limited verification beyond static analysis. Additionally, active lint errors exist in geo.calc.ts (explicit any usage) and About.tsx (missing hook dependencies). Fix these to ensure long-term maintainability.
Findings
TEST: Critically missing test coverage for 244 changed source files.
ARCH: explicit any usage in regional normalization logic; bypassing type safety.
ARCH: Missing dependency in useEffect in About.tsx.
Thank you for the reviews! I have addressed the findings:
Lint: Fixed the any usage in geo.calc.ts and the missing dependency in About.tsx.
Tests: Restored basic unit testing infrastructure by adding a test for utils.ts and updating vitest.config.ts coverage thresholds to match the new architecture (src/features, src/workers, src/shared). Note that there is still a significant lack of coverage that should be addressed before merging.
ARCH (geo.calc.ts): Fixed. Removed explicit any by importing and using the centralized normalizeStateCode utility with proper type safety.
ARCH (About.tsx): Fixed. Resolved useEffect dependency warning by moving the static STEPS configuration outside of the component.
TEST: Started restoration of the test suite. Added a new unit test for core utilities and updated coverage thresholds to reflect the new architecture. More coverage is planned as a follow-up.
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
While the PR claims to resolve critical stability issues—specifically memory leaks in the search worker and race conditions during data source switching—there is no evidence of automated testing to prevent regressions in these areas. The scope is unusually broad, mixing infrastructure (Docker/CI) with frontend feature development (Analytics), which complicates the review and increases the risk of side effects.
Codacy analysis shows the PR is technically up to standards regarding static analysis, but the lack of verification for the primary functional requirements and bug fixes remains a significant concern. The absence of linked documentation or Jira tickets further obscures the original requirements.
About this PR
Critical bug fixes for memory leaks and race conditions are included, but there is no mention of new automated tests to verify these fixes. Relying on manual review for memory-related and concurrency issues is insufficient.
The PR scope is extremely broad, combining unrelated frontend feature work with foundational infrastructure changes, which complicates the review process and increases the risk of side effects.
Jira ticket information is missing, leaving the business context and original requirements for the new visualization components unlinked.
Test suggestions
Render the prize pyramid chart with hierarchical data sets.
Verify Docker container health check accurately reflects service readiness.
Validate search worker client resource cleanup after heavy search operations to ensure no memory leaks.
Simulate rapid data source switching to verify seeding state consistency and absence of race conditions.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Render the prize pyramid chart with hierarchical data sets.
2. Verify Docker container health check accurately reflects service readiness.
3. Validate search worker client resource cleanup after heavy search operations to ensure no memory leaks.
4. Simulate rapid data source switching to verify seeding state consistency and absence of race conditions.
- Reescrever descrições para maior clareza em README.md e HeroSection.tsx
- Padronizar 'Página Inicial' com maiúscula
- Corrigir espaço extra em notas de data.json
- Trocar 'Stack Tecnológica' para 'Pilha Tecnológica'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
henriquebonfim
changed the title
henriquebonfim
left a comment
![codacy-production[bot]](https://avatars.githubusercontent.com/in/56611?s=60&v=4){kind=small}
Overview
This PR delivers a significant upgrade to both the product and development infrastructure. It overhauls the analytics dashboard with modern charts and reorganized components while simultaneously standardizing the development environment with updated Docker configurations, CI pipelines, and linting rules.
Major Changes
Bug Fixes & Refinements (from Code Review)
Type of change
How has this been tested?
Changes were verified via static analysis, type checking, and manual review of the analytics components.
Checklist: