Skip to content

Address PR 22 review feedback - #23

Merged
hbmartin merged 1 commit into
mainfrom
pr20-review-fixes
Aug 2, 2026
Merged

Address PR 22 review feedback#23
hbmartin merged 1 commit into
mainfrom
pr20-review-fixes

Conversation

@hbmartin

@hbmartin hbmartin commented Aug 2, 2026

Copy link
Copy Markdown
Owner
  • Remove unused StatsPanel.show_model
  • Assert cleared submodel options via public OptionList API
  • Use expect_type keyword in all Textual query_one calls
  • Correct step-label fallback comment

Summary by cubic

Make Textual widget queries type-safe, remove an unused stats method, and clear submodel options via the public selector API. This improves reliability across model/error states and aligns tests with the behavior.

  • Refactors

    • Use expect_type in all query_one calls for explicit widget types.
    • Remove StatsPanel.show_model.
    • Clarify the step-label fallback comment; update tests to use expect_type and verify selector state.
  • Bug Fixes

    • Clear submodel selector via the public OptionList API so error loads leave a single empty option (no private attributes).

Written for commit 48ed98f. Summary will update on new commits.

Review in cubic

- Remove unused StatsPanel.show_model
- Assert cleared submodel options via public OptionList API
- Use expect_type keyword in all Textual query_one calls
- Correct step-label fallback comment

Co-Authored-By: Claude Fable 5 <[email protected]>
@gemini-code-assist

Copy link
Copy Markdown

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@coderabbitai

coderabbitai Bot commented Aug 2, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 54 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 3b8cf710-d399-4668-bb8c-83802c331947

📥 Commits

Reviewing files that changed from the base of the PR and between 208cf1f and 48ed98f.

📒 Files selected for processing (9)
  • src/pyldraw3_tui/app.py
  • src/pyldraw3_tui/screens/catalog.py
  • src/pyldraw3_tui/screens/model.py
  • src/pyldraw3_tui/screens/setup.py
  • src/pyldraw3_tui/widgets/part_detail.py
  • src/pyldraw3_tui/widgets/stats_panel.py
  • tests/test_pilot_catalog.py
  • tests/test_pilot_model.py
  • tests/test_snapshots.py

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Aug 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.16129% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.49%. Comparing base (64161d2) to head (48ed98f).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/pyldraw3_tui/screens/setup.py 0.00% 2 Missing ⚠️
src/pyldraw3_tui/app.py 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #23      +/-   ##
==========================================
+ Coverage   87.44%   87.49%   +0.05%     
==========================================
  Files          30       30              
  Lines        1465     1463       -2     
==========================================
- Hits         1281     1280       -1     
+ Misses        184      183       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hbmartin
hbmartin merged commit 172e445 into main Aug 2, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant