Skip to content

Add basic thread support#126

Open
pmacg wants to merge 8 commits into
haskellcamargo:masterfrom
pmacg:add-threads
Open

Add basic thread support#126
pmacg wants to merge 8 commits into
haskellcamargo:masterfrom
pmacg:add-threads

Conversation

@pmacg

@pmacg pmacg commented Aug 29, 2019

Copy link
Copy Markdown

This change adds some very basic thread support to the application:

  • If a message in a channel has replies, show the number of messages in the thread
  • Pressing 't' on a particular message shows a thread view with just the messages in the thread
  • Pressing 't' on a message in a thread returns to the channel
  • Posting a message while viewing a thread will post the message in the thread rather than in the channel

Resolves Issue #125 .

@pmacg

pmacg commented Aug 30, 2019

Copy link
Copy Markdown
Author

Actually addresses #105

@pmacg pmacg mentioned this pull request Aug 30, 2019
@k4ml

k4ml commented Oct 10, 2019

Copy link
Copy Markdown

Seem to work so far. This PR prevent me from going away ;)

@mitas

mitas commented Oct 10, 2019

Copy link
Copy Markdown

@k4ml me too

@icyJoseph

Copy link
Copy Markdown

@pmacg I too vouch for this PR, seems to work swell. @haskellcamargo any comments?

@haskellcamargo

Copy link
Copy Markdown
Owner

I'm gonna take a look on this PR tomorrow! I'm excited for thread support as well.

@jtagcat

jtagcat commented Apr 19, 2020

Copy link
Copy Markdown

It is April, Slack has rolled out it's new slower than ever UI. I can see the last word being typed while typing the next word. Any updates?

@ubuntudroid

Copy link
Copy Markdown

Is this still being worked on?

@pmacg

pmacg commented Oct 6, 2020

Copy link
Copy Markdown
Author

Is this still being worked on?

I'm not still working on it and I actually no longer use slack, so I won't know if it breaks!

The PR is just waiting for approval from @haskellcamargo

@james-see

Copy link
Copy Markdown

@haskellcamargo anything? can we merge if it works?

@duynguyenhoang

Copy link
Copy Markdown
Collaborator

Thank you for this effort, I will test and merge it ASAP. Sorry I am quite busy recently and unable to check all PRs

@jotech

jotech commented Nov 23, 2020

Copy link
Copy Markdown

any updates on this? I checked the pull request locally and it seems to work with base branch!

@satelliteoflove

Copy link
Copy Markdown

@duynguyenhoang do you have any updates on this? Many thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.