Added pull request template#175
Open
sonamtenzin2 wants to merge 2 commits into
Open
Conversation
mukeshjc
previously approved these changes
Apr 16, 2025
jrasell
reviewed
Apr 16, 2025
Comment on lines
+10
to
+14
| - [JIRA](https://hashicorp.atlassian.net/browse/xxxx) | ||
| - [RFC](https://docs.google.com/document/d/xxxx) | ||
| - [PRD](https://docs.google.com/document/d/xxxx) | ||
| - [Related PR](https://github.com/hashicorp/atlas/pull/xxxx) | ||
| - [Documentation](https://github.com/hashicorp/terraform-docs-common/pull/xxxx) |
Member
There was a problem hiding this comment.
Is there a reason for these link examples?
This is a public repository, so external contributors won't be using Jira, RFCs, or PRDs and it's likely internal contributors won't have 2 of these 3 links depending on the PR request purpose. The bottom two are "randomly selected" pointers, one of which is not a public repo. I am of the opinion these should be removed.
sonamtenzin2
force-pushed
the
sonamt/pr-desc
branch
from
May 9, 2025 07:21
1c0ed55 to
886cb4c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.