fix(facet): skip tick-label padding when axis text is blank#1079
Merged
Conversation
theme(text=element_blank()) removes the specific axis-text themeables,
so theme.get_margin('axis_text_x') resolves to None and
set_limits_breaks_and_labels crashed on None.pt. Guard each axis with
theme.T.is_blank(...) and skip tick_params when the axis text is blank
(it is not drawn, so the pad is irrelevant).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
theme(text=element_blank())removes the specific axis-text themeables, sotheme.get_margin('axis_text_x')resolves to None and led to an exception.Solution is to guard each axis with
theme.T.is_blank(...).