chore: migrate from Endpoints to endpointSlice#73
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the e2e suite’s metrics-service readiness check to use Kubernetes EndpointSlice resources instead of the deprecated Endpoints API, aligning the test with the ongoing migration work referenced in harvester/harvester#9381.
Changes:
- Switch the e2e “metrics endpoint ready” verification from
kubectl get endpointstokubectl get endpointslicesfiltered bykubernetes.io/service-name.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
206
to
210
| cmd := exec.Command("kubectl", "get", "endpointslices", "-n", namespace, | ||
| "-l", "kubernetes.io/service-name="+metricsServiceName, "-o", "yaml") | ||
| output, err := utils.Run(cmd) | ||
| g.Expect(err).NotTo(HaveOccurred()) | ||
| g.Expect(output).To(ContainSubstring("8443"), "Metrics endpoint is not ready") |
Signed-off-by: Vicente Cheng <[email protected]>
Vicente-Cheng
force-pushed
the
move-to-endpointslice
branch
from
July 13, 2026 12:59
d545849 to
317ffb9
Compare
pohanhuang
approved these changes
Jul 14, 2026
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
We need to migrate from Endpoints to endpointSlice.
REF: https://kubernetes.io/blog/2025/04/24/endpoints-deprecation/
Solution:
migrate from Endpoints to endpointSlice
Related Issue(s):
harvester/harvester#9381
Test plan:
Additional documentation or context