chore: bump harvester to v1.8.0-rc6#65
Conversation
Signed-off-by: Zespre Chang <[email protected]>
There was a problem hiding this comment.
Pull request overview
This PR updates the module dependencies for github.com/harvester/upgrade-toolkit, primarily bumping the Harvester dependency to v1.8.0-rc6 and refreshing related transitive dependencies.
Changes:
- Bump
github.com/harvester/harvesterfromv1.8.0-rc1tov1.8.0-rc6. - Upgrade several direct/indirect dependencies (e.g.,
longhorn-manager,ginkgo/gomega, Prometheus libs, some Kubernetes libs). - Regenerate
go.sumto reflect updated dependency graph.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| go.mod | Updates required module versions (Harvester + related deps), introduces/adjusts several indirect versions. |
| go.sum | Updates module checksums to match the new resolved dependency set. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| k8s.io/api v0.34.1 | ||
| k8s.io/apimachinery v0.34.1 |
There was a problem hiding this comment.
These k8s.io/api and k8s.io/apimachinery version bumps to v0.34.1 are currently overridden by the replace directives at the top of this file that pin both modules to v0.33.7. As-is, the upgrade won’t actually take effect and the go.mod state is misleading. Please either update/remove the corresponding replace entries to match the intended v0.34.1 versions, or revert these require bumps to align with the replacements.
| k8s.io/api v0.34.1 | |
| k8s.io/apimachinery v0.34.1 | |
| k8s.io/api v0.33.7 | |
| k8s.io/apimachinery v0.33.7 |
| k8s.io/apiextensions-apiserver v0.34.1 // indirect | ||
| k8s.io/apiserver v0.34.1 // indirect | ||
| k8s.io/component-base v0.34.1 // indirect |
There was a problem hiding this comment.
These k8s.io/* bumps to v0.34.1 are also overridden by the replace block (which pins k8s.io/apiextensions-apiserver, k8s.io/apiserver, and k8s.io/component-base to v0.33.7). To avoid confusion and ensure the intended versions are actually used, please keep the require versions consistent with the active replace directives (or update/remove the replaces).
| k8s.io/apiextensions-apiserver v0.34.1 // indirect | |
| k8s.io/apiserver v0.34.1 // indirect | |
| k8s.io/component-base v0.34.1 // indirect | |
| k8s.io/apiextensions-apiserver v0.33.7 // indirect | |
| k8s.io/apiserver v0.33.7 // indirect | |
| k8s.io/component-base v0.33.7 // indirect |
| github.com/harvester/harvester v1.8.0-rc6 | ||
| github.com/longhorn/longhorn-manager v1.10.0 | ||
| github.com/onsi/ginkgo/v2 v2.28.0 | ||
| github.com/onsi/gomega v1.39.1 |
There was a problem hiding this comment.
The PR title suggests this change is only a Harvester bump, but this hunk also upgrades several other dependencies (e.g., longhorn-manager, ginkgo/gomega, k8s.io/api/apimachinery, wrangler). Either narrow the dependency changes to match the stated scope, or update the PR title/description to reflect the broader upgrade set so reviewers know to validate those components too.
|
@mergify backport v1.8 |
✅ Backports have been createdDetails
|
(cherry picked from commit 1f2b0cd) Signed-off-by: Zespre Chang <[email protected]> Co-authored-by: Zespre Chang <[email protected]>
Problem:
Solution:
Related Issue(s):
Test plan:
Additional documentation or context