fix(upgrade): add Plans to place/remove .skip files on RKE2 manifests (backport #62)#64
Merged
Merged
Conversation
…#62) * fix: add Plans to place/remove .skip files on RKE2 manifests Ported from harvester/harvester#10402. Before multi-node node upgrades begin, an SUC Plan creates rke2-multus.yaml.skip files on all managed nodes to prevent RKE2 from upgrading the rke2-multus chart release mid-upgrade. The .skip files are removed during finalization or on UpgradePlan deletion. Signed-off-by: Zespre Chang <[email protected]> * fix: handle skip-manifest removal failure and always attempt cleanup Signed-off-by: Zespre Chang <[email protected]> * fix: add SecurityContext to skip-manifest and image-cleanup SUC plans Signed-off-by: Zespre Chang <[email protected]> --------- Signed-off-by: Zespre Chang <[email protected]> (cherry picked from commit 5db10d6)
starbops
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
Solution:
Before multi-node node upgrades begin, an SUC Plan creates rke2-multus.yaml.skip files on all managed nodes to prevent RKE2 from upgrading the rke2-multus chart release mid-upgrade. The .skip files are removed during finalization or on UpgradePlan deletion.
Related Issue(s):
harvester/harvester#10359
Test plan:
Additional documentation or context
Ported from harvester/harvester#10402.
This is an automatic backport of pull request #62 done by Mergify.