fix(upgrade): patch rke2-multus failurePolicy to abort (backport #59)#63
Merged
Conversation
Signed-off-by: Zespre Chang <[email protected]> Co-authored-by: Jian Wang <[email protected]> (cherry picked from commit 9307270)
starbops
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
rke2-multus upgrade can fail during the node-upgrade phase. According to the Klipper logic, it will try to uninstall before upgrading a failed chart release. This is considered disastrous because the NAD CRD will be deleted, and all the user-created NADs will be purged as well.
Solution:
Disabling the rke2-multus chart upgrade during the node-upgrade phase by dropping .skip files on each node. After the node-upgrade phase is passed, remove those .skip files and let the Helm controller do the upgrade for rke2-multus.
Related Issue(s):
harvester/harvester#10359
Test plan:
starbops/harvester-upgrade-toolkit:feat-patch-rke2-multus-failure-policy-head)failurePolicyshould be set toabortfor therke2-multusHelmChartConfigAdditional documentation or context
Porting changes from harvester/harvester#10366
This is an automatic backport of pull request #59 done by Mergify.