fix: missing harvesterhci.io/sshNames issue#2771
Open
asc5543 wants to merge 1 commit into
Open
Conversation
Signed-off-by: asc5543 <[email protected]>
irishgordo
approved these changes
Jul 17, 2026
irishgordo
left a comment
irishgordo
left a comment
Contributor
There was a problem hiding this comment.
thanks for the fix @asc5543 lgtm 😄
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Issue #2756
What this PR does / why we need it:
Python script is missing the
harvesterhci.io/sshNamesannotation when creating the VM template, which causes a JSON unmarshalling error (AssertionError: (500, 'unexpected end of JSON input')) at handler.go#L1501.After adding the
harvesterhci.io/sshNames, the issue is gone.Special notes for your reviewer:
Additional documentation or context
The test pass.
