Skip to content

Fix deleting while exporting#2760

Merged
khushboo-rancher merged 4 commits into
harvester:mainfrom
Vicente-Cheng:fix-deleting-while-exporting
Jul 14, 2026
Merged

Fix deleting while exporting#2760
khushboo-rancher merged 4 commits into
harvester:mainfrom
Vicente-Cheng:fix-deleting-while-exporting

Conversation

@Vicente-Cheng

@Vicente-Cheng Vicente-Cheng commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Which issue(s) this PR fixes:

Issue #

What this PR does / why we need it:

  • fix the timing issue for deleting while exporting failure
  • fix the skip mechanism that did not work correctly on backup tests
  • fix some backup CRDs that were not cleaned up

Special notes for your reviewer:

Additional documentation or context

@Vicente-Cheng

Copy link
Copy Markdown
Contributor Author

Test result:

2026-07-11 04:50:16.690101 [PID:25] [5] [ID:5] EXECUTING Tests.Regression.Vm.Test Vm Operations
2026-07-11 04:50:16.691366 [PID:27] [6] [ID:6] EXECUTING Tests.Regression.Vm.Test Vm Volumes
2026-07-11 04:50:16.691536 [PID:26] [3] [ID:3] EXECUTING Tests.Regression.Vm.Test Vm
2026-07-11 04:50:16.695741 [PID:37] [0] [ID:0] EXECUTING Tests.Regression.Backup.Test Vm Backup
2026-07-11 04:50:16.698841 [PID:40] [2] [ID:2] EXECUTING Tests.Regression.Image.Test Image Negative
2026-07-11 04:50:16.699341 [PID:41] [7] [ID:7] EXECUTING Tests.Regression.Volume.Test Volume
2026-07-11 04:50:16.702972 [PID:49] [4] [ID:4] EXECUTING Tests.Regression.Vm.Test Vm Negative
2026-07-11 04:50:16.703731 [PID:50] [1] [ID:1] EXECUTING Tests.Regression.Image.Test Image
2026-07-11 04:50:17.603011 [PID:37] [0] [ID:0] PASSED Tests.Regression.Backup.Test Vm Backup in 0.9 seconds
2026-07-11 04:50:17.609974 [PID:57] [0] [ID:8] EXECUTING Tests.Regression.Volume.Test Volume Negative
...
53 tests, 46 passed, 0 failed, 7 skipped.
===================================================

You can see the backup completed very fast and was marked as skipped.
(Previously, we needed to wait for a 10-minute timeout)

bk201
bk201 previously approved these changes Jul 11, 2026
@mergify

mergify Bot commented Jul 11, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

    we need to ensure whole backup related CRs were cleanup

Signed-off-by: Vicente Cheng <[email protected]>
@Vicente-Cheng
Vicente-Cheng force-pushed the fix-deleting-while-exporting branch from 8d651e1 to f737b3f Compare July 12, 2026 06:51
@khushboo-rancher
khushboo-rancher merged commit b6afb5d into harvester:main Jul 14, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants