fix: always sync monut point instead of skipping#345
Merged
Conversation
Yu-Jack
force-pushed
the
HARV-8990-fix
branch
7 times, most recently
from
July 13, 2026 06:39
1994bc4 to
cfe04d9
Compare
1 task
Yu-Jack
force-pushed
the
HARV-8990-fix
branch
3 times, most recently
from
July 13, 2026 08:00
c0a60a1 to
5726bb3
Compare
Yu-Jack
commented
Jul 13, 2026
Yu-Jack
marked this pull request as ready for review
July 13, 2026 10:02
Contributor
Author
|
@mergify backport v1.9 |
Contributor
✅ Backports have been createdDetails
|
Yu-Jack
force-pushed
the
HARV-8990-fix
branch
2 times, most recently
from
July 14, 2026 03:08
df03020 to
489dfd0
Compare
Signed-off-by: Jack Yu <[email protected]>
Vicente-Cheng
approved these changes
Jul 14, 2026
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
The original solution of #317 is a bit risky because it could delete the blockdevices.
Solution:
We just patch the mounted information back instead of removing the block device. Then, frontend can filter or mark that this device has been mounted somewhere.
Users can decide whether they'd like to unmount and use it or just ignore it.
Also, BTW, fix the CI issue.
Related Issue:
harvester/harvester#8990
frontend: harvester/harvester-ui-extension#987
Test plan:
