Mention Image Volume Size Check in 1.9.x to 1.10.x upgrade - #1122
Open
votdev wants to merge 1 commit into
Open
Conversation
|
votdev
force-pushed
the
issue_10351_img_size_validator
branch
from
September 2, 2026 10:01
e519fb2 to
5d74f41
Compare
|
|
||
| ### Image Volume Size Check | ||
|
|
||
| Prior to v1.10.0, Harvester did not validate that a volume created from a VM image was at least as large as the image's virtual size. A volume smaller than its source image can lead to data integrity issues once the guest OS writes past the shrunk backing store. Starting with v1.10.0, Harvester rejects any new volume request that violates this constraint, but volumes created before the upgrade may still be affected. |
Member
There was a problem hiding this comment.
The image volume check should already be merged and included starting from v1.9.0, right?
WebberHuang1118
left a comment
WebberHuang1118
left a comment
Member
There was a problem hiding this comment.
Should we provide a way to check the image volume size before starting the upgrade, similar to the pre-check script described here?
Member
Author
votdev
force-pushed
the
issue_10351_img_size_validator
branch
from
September 4, 2026 12:48
5d74f41 to
c7c52ea
Compare
Related to: harvester/harvester#10351 Related to: harvester/harvester#11315 Related to: harvester/upgrade-helpers#53 Signed-off-by: Volker Theile <[email protected]>
votdev
force-pushed
the
issue_10351_img_size_validator
branch
from
September 4, 2026 13:09
c7c52ea to
af27cfc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caution
ONLY MERGE AFTER v1.9.0 is released and tagged.
The following changes are applied by the PR:
Image Volume Size Checkthat is performed during the upgrade from v1.9.x to v1.10.0.sidebar_positionin the front matter of all MD files belowdocs/upgrade.v1.8.x to v1.9.0is added as an empty template. Should be added tomainbranch soonish when v1.9.0 is released.Related to: harvester/harvester#10351
Problem:
Solution:
Related Issue(s):
Test plan:
Additional documentation or context