fix(scrybe-app): socket quit exits the process, not just the window - #233
Merged
Conversation
The scrybe://cli-quit listener closed the main window and trusted window-close-exits-app; in practice the close request left the PROCESS and the cli_rpc socket alive — a half-dead app agents could keep driving. The deleted pkill fallback (#207) had masked this for the app's whole life; the #192 UAT harness caught it on its first local run (quit --force → 5s later the socket still served reads). New quit_app command (AppHandle::exit(0) — no process plugin) invoked after the frontend's dirty checks; best-effort socket-file unlink first since exit skips destructors (a stale socket is typed not-running by clients, #211, but tidy beats stale). Regression coverage: the #192 UAT script's "socket quit stops the app" check (headless harness), which is how this was found. Fixes #232 Co-Authored-By: Claude Opus 4.8 (gnuc orchestrator) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The #192 UAT gate's first catch, before it even merged.
scrybe quit --forcereturned success while the process and socket stayed alive (verified: 5s laterscrybe readstill served the buffer) — the deleted pkill fallback had masked this since forever. Fix:quit_appcommand (AppHandle::exit(0), no plugin) after the dirty checks + best-effort socket unlink (exit skips destructors; stale sockets are typed not-running per #211 anyway). Verified with the same headless probe: process exits. Regression lives in the incoming #192 UAT script. Fixes #232