Rework math text editing to normalize user input to LaTeX#59
Open
shreekardittakavi wants to merge 5 commits into
Open
Rework math text editing to normalize user input to LaTeX#59shreekardittakavi wants to merge 5 commits into
shreekardittakavi wants to merge 5 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
52a525d to
ddf574c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements #58.
LatexMarkdownrenderer.mathblocks on editor load, autosave, paste/import, and API persistence.$...$and\(...\)note math inline using the existingnote-inline-mathspan format.Verification
pnpm test lib/notes/math-regions.test.ts lib/notes/parse-markdown.test.ts lib/notes/markdown.test.ts lib/notes/persistence.test.ts components/note-editor/note-editor.test.tsxpnpm lintpasses with one existing warning incomponents/note-editor/code-block-view.tsxpnpm testpnpm build